Skip to content

chore(ci): run compliance harness 1.13.1 once per codec - #1026

Merged
eli-r-ph merged 3 commits into
v1from
v1-capture-harness
Oct 14, 2026
Merged

eli-r-ph merged 3 commits into
v1from
v1-capture-harness

Conversation

@eli-r-ph

@eli-r-ph eli-r-ph commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

💡 Motivation and Context

Stacked on #1025. The compliance harness skipped the AI lane and event options for this SDK, and its reusable workflow failed when posting a PR comment. This PR runs harness 1.13.1 with every capture suite the SDK supports, once per codec.

Changes

  • The adapter advertises capture_ai_v1 and event_options, so both suites run.
  • /capture and /capture_ai share one handler that passes options, properties and uuid to the SDK unchanged.
  • The adapter takes its codec from COMPRESSION (gzip, deflate or zstd; default gzip).
  • CI runs one harness job per codec; there is no brotli job, because the SDK has no brotli support.
  • The report goes to the job summary and an artifact, so the workflow needs only contents: read.

No SDK code changes.

💚 How did you test it?

  • The harness passed locally for each codec (223 tests for gzip, 221 for deflate and zstd).
  • New adapter tests catch a wrong codec capability and options or uuid that the adapter changes.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Written with Cursor (Claude Opus) under the direction of the assignee.

🤖 Generated with Claude Code

@eli-r-ph eli-r-ph self-assigned this Oct 7, 2026
@eli-r-ph eli-r-ph mentioned this pull request Oct 7, 2026
3 of 20 tasks
@eli-r-ph
eli-r-ph force-pushed the v1-capture-harness branch from f2faf4d to 743d8ca Compare October 7, 2026 17:43
@eli-r-ph
eli-r-ph force-pushed the v1-capture-ai-personless-option branch from 3f09f03 to 5e3fddc Compare October 7, 2026 17:43
@eli-r-ph

eli-r-ph commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai review

@eli-r-ph
eli-r-ph marked this pull request as ready for review October 7, 2026 20:44
@eli-r-ph
eli-r-ph requested a review from a team as a code owner October 7, 2026 20:44

@dustinbyrne dustinbyrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expanded compliance matrix and adapter forwarding look sound. Existing CI exercises both capture lanes across all three codecs. One small documentation follow-up: the standalone adapter-test setup needs the zstd extra.

AI-assisted review.

Comment thread sdk_compliance_adapter/test_adapter.py
@eli-r-ph
eli-r-ph force-pushed the v1-capture-harness branch from 743d8ca to ca9c26c Compare October 8, 2026 16:25
@eli-r-ph
eli-r-ph force-pushed the v1-capture-ai-personless-option branch from 5e3fddc to 09f7144 Compare October 8, 2026 16:25
@eli-r-ph
eli-r-ph force-pushed the v1-capture-harness branch from ca9c26c to e743d1e Compare October 8, 2026 18:13
@eli-r-ph
eli-r-ph force-pushed the v1-capture-ai-personless-option branch from 09f7144 to 1355d44 Compare October 8, 2026 18:13
@eli-r-ph
eli-r-ph force-pushed the v1-capture-harness branch from e743d1e to 78973e7 Compare October 8, 2026 21:12
@eli-r-ph
eli-r-ph force-pushed the v1-capture-ai-personless-option branch 2 times, most recently from 316f808 to b46dbfa Compare October 8, 2026 22:54
@eli-r-ph
eli-r-ph force-pushed the v1-capture-harness branch 2 times, most recently from 9dcf4df to d31608d Compare October 8, 2026 23:40
@eli-r-ph
eli-r-ph force-pushed the v1-capture-ai-personless-option branch 2 times, most recently from 233dc8a to ed8a8d4 Compare October 10, 2026 23:35
@eli-r-ph
eli-r-ph force-pushed the v1-capture-harness branch 2 times, most recently from 5c2b03e to 41336ea Compare October 11, 2026 20:17
@eli-r-ph
eli-r-ph force-pushed the v1-capture-ai-personless-option branch from ed8a8d4 to 0adfafd Compare October 11, 2026 20:17
@eli-r-ph
eli-r-ph force-pushed the v1-capture-ai-personless-option branch 2 times, most recently from b25f805 to 608878e Compare October 14, 2026 03:46
Base automatically changed from v1-capture-ai-personless-option to v1 October 14, 2026 03:46
The adapter now advertises capture_ai_v1 and event_options, passes options and uuids through unchanged, and takes its codec from COMPRESSION. The workflow runs the harness containers directly in a gzip/deflate/zstd matrix, so it no longer needs pull-requests: write.
The standalone adapter-test setup installs the zstd extra, matching CI.
@eli-r-ph
eli-r-ph merged commit 49399ed into v1 Oct 14, 2026
39 checks passed
@eli-r-ph
eli-r-ph deleted the v1-capture-harness branch October 14, 2026 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants